Tidy it up and make Pull Request#
When you are in the seaduck
directory and feel like you are finished with your changes, just before you submit everything, simply run
make
This will do the style check and run pytest. If you followed the steps in “prepare the environment”, everything here should pass.
Make sure before you push everything is committed.
git add .
git commit -m "A description of the good stuff you have done"
Tip
Sometimes the style check will make changes to the file, make sure you commit after that.
Alternatively, you could ask pre-commit
to run every time you commit by running pre-commit install
.
If everything passed then
git push -u origin name_of_your_branch
Now open your forked directory, you should be able to “start a pull request” by clicking around.
Now, wait for Mr. Duckmaster to merge your branch into the main branch.